Skip to content

ApiTestCase and assertions docs#875

Merged
dunglas merged 2 commits into
api-platform:masterfrom
dunglas:testing
Sep 24, 2019
Merged

ApiTestCase and assertions docs#875
dunglas merged 2 commits into
api-platform:masterfrom
dunglas:testing

Conversation

@dunglas

@dunglas dunglas commented Sep 23, 2019

Copy link
Copy Markdown
Member

@dunglas dunglas mentioned this pull request Sep 23, 2019
Merged
4 tasks
@meyerbaptiste meyerbaptiste mentioned this pull request Sep 23, 2019
Merged
@dunglas dunglas mentioned this pull request Sep 23, 2019
Merged
@teohhanhui teohhanhui mentioned this pull request Sep 23, 2019
Merged
dunglas
dunglas commented Sep 23, 2019
View reviewed changes
Comment thread distribution/testing.md
In addition to integration tests written using the helpers provided by `ApiTestCase`, all the classes of your project should be covered by [unit tests](https://en.wikipedia.org/wiki/Unit_testing).
To do so, learn how to write unit tests with [PHPUnit](https://phpunit.de/index.html) and [its Symfony/API Platform integration](https://symfony.com/doc/current/testing.html).

## Additional and Alternative Testing Tools

@dunglas dunglas Sep 23, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should we drop entirely this section. I'm not sure it's still relevant/wanted.

@dunglas dunglas mentioned this pull request Sep 23, 2019
Closed
bendavies
bendavies reviewed Sep 23, 2019
View reviewed changes
Comment thread core/testing.md Outdated
bendavies
bendavies reviewed Sep 23, 2019
View reviewed changes
Comment thread core/testing.md Outdated
bendavies
bendavies reviewed Sep 23, 2019
View reviewed changes
Comment thread core/testing.md Outdated
bendavies
bendavies reviewed Sep 23, 2019
View reviewed changes
Comment thread core/testing.md Outdated
bendavies
bendavies reviewed Sep 23, 2019
View reviewed changes
Comment thread core/testing.md Outdated
bendavies
bendavies reviewed Sep 23, 2019
View reviewed changes
Comment thread distribution/testing.md Outdated
bendavies
bendavies reviewed Sep 23, 2019
View reviewed changes
Comment thread distribution/testing.md Outdated
@dunglas

dunglas commented Sep 23, 2019

Copy link
Copy Markdown
Member Author

Thanks for the review @bendavies!!

@dunglas
dunglas merged commit 62ee8d9 into api-platform:master Sep 24, 2019
@dunglas
dunglas deleted the testing branch September 24, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teohhanhui teohhanhui Awaiting requested review from teohhanhui
@meyerbaptiste meyerbaptiste Awaiting requested review from meyerbaptiste
1 more reviewer
@bendavies bendavies bendavies left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dunglas @bendavies